Fix Bug of Parameters Controls in cfg_altiumWorkspace and add Feature Group componets for footprint size(with test) #24
Conversation
… Group componets for footprint size
lib/cfg.py
Outdated
| @@ -300,6 +302,7 @@ def cfg_altiumWorkspace(workspace_file_path, csv_file, bom_search_dir, | |||
| logger.info("Root path %s\n" % root_path) | |||
|
|
|||
| wk_config = ConfigParser.RawConfigParser() | |||
| print("Sono qui%s" %(workspace_file_path)) | |||
There was a problem hiding this comment.
Le print di debug non si committano, se sono messaggi utenti o che hanno senso che rimangono usare il logger.
lib/cfg.py
Outdated
| merge_file_itemNoPath = os.path.join(file_to_merge_path,bom_name)+ '.csv' | ||
|
|
||
| print(os.path.exists(merge_file_item)) | ||
| print(os.path.exists(merge_file_itemNoPath)) |
lib/cfg.py
Outdated
| @@ -348,23 +351,35 @@ def cfg_altiumWorkspace(workspace_file_path, csv_file, bom_search_dir, | |||
| bom_name = "%s%s%s" % (bom_prefix, basename, bom_postfix) | |||
| path_file = os.path.join(file_to_merge_path, basename) | |||
| merge_file_item = os.path.join(path_file, bom_name) + '.csv' | |||
| merge_file_itemNoPath = os.path.join(file_to_merge_path,bom_name)+ '.csv' | |||
There was a problem hiding this comment.
Per il coding style fare riferimento al PEP8. https://www.python.org/dev/peps/pep-0008/
| @@ -348,23 +351,35 @@ def cfg_altiumWorkspace(workspace_file_path, csv_file, bom_search_dir, | |||
| bom_name = "%s%s%s" % (bom_prefix, basename, bom_postfix) | |||
| path_file = os.path.join(file_to_merge_path, basename) | |||
| merge_file_item = os.path.join(path_file, bom_name) + '.csv' | |||
There was a problem hiding this comment.
Il programma deve funzionare sia con i csv che con i file excel. Per sapere quando siamo in un caso o in un altro utilizzare la variabile csv_file
There was a problem hiding this comment.
Aggiunger un test specifico per i due casi, creando dentro la cartella test un workspace completo (vedi altri file nei test) e aggiungere due progetti uno con csv e uno con excel.
lib/cfg.py
Outdated
| print("NO") | ||
| logger.error("Warning empty parameters\n") | ||
| else: | ||
| print("OK") |
lib/lib.py
Outdated
| @@ -35,6 +35,11 @@ def order_designator(ref_str, logger): | |||
| sys.exit(1) | |||
| return ", ".join(d) | |||
|
|
|||
| def oreder_footprint(ref_str,logger): | |||
There was a problem hiding this comment.
Ti sei scordato funzioni a giro che non usi anche con errori.. togliere.
PS: dopo la virgola si mette uno spazio..
merge_test.py
Outdated
| @@ -844,7 +913,8 @@ def test_cliCSV(self): | |||
| suite.addTest(TestMergeBom("test_mergedFile")) | |||
| suite.addTest(TestMergeBom("test_stats")) | |||
| suite.addTest(TestMergeBom("test_notPopulate")) | |||
| suite.addTest(TestMergeBom("test_otherColumn")) | |||
| #suite.addTest(TestMergeBom("test_otherColumn")) | |||
There was a problem hiding this comment.
Anche questo test deve funzionare..
No description provided.