Update queues.conf.sample - PJSIP reports 'in use'. #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested the PJSIP channel driver and determined it correctly reports 'in use'.
|
|
jcolp
requested changes
Apr 15, 2024
There was a problem hiding this comment.
The commit message should be updated to conform to standard:
https://docs.asterisk.org/Development/Policies-and-Procedures/Commit-Messages/?h=commit+message
Additionally a comment needs to be added for where this is to be cherry picked:
https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/#cherry-picking
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
|
This PR has been closed because it has been in "Changes Requested" or "submitter-action-required" state for more than 42 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested the PJSIP channel driver and determined the ringinuse feature works correctly with chan_pjsip.