chan_pjsip: Add the same details as PJSIPShowContacts to the CLI via 'pjsip show contact' #644
Conversation
|
Fixes #643 |
github-actions
bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment with If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add The currently active branches are now 18, 20, 21 and master. |
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-tests-failed
labels
There was a problem hiding this comment.
The 'Fixes" line needs to be in the original PR description, not an additional comment, as well as in the commit message.
You also need the "cherry-pick" lines.
See:
https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/
https://docs.asterisk.org/Development/Policies-and-Procedures/Commit-Messages/
…'pjsip show contact' CLI 'pjsip show contact' does not show enough information. One must telnet to AMI or write a script to ask Asterisk for example what the User-Agent is on a Contact This feature adds the same details as PJSIPShowContacts to the CLI Resolves: asterisk#643
intellasoft
force-pushed
the
master-issue-643
branch
from
3eeef72
to
4a64fa0
Compare
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-passed
labels
|
cherry-pick-to: none |
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
That is a lot of code to change to pass a boolean down to a single callback. There is no better way? If not, all of the header documentation needs to be updated to include the new |
| @@ -1135,11 +1137,102 @@ static int cli_contact_print_body(void *obj, void *arg, int flags) | |||
| ast_sip_get_contact_short_status_label(status ? status->status : UNKNOWN), | |||
| (status && (status->status == AVAILABLE)) ? ((long long) status->rtt) / 1000.0 : NAN); | |||
|
|
|||
| if (flags & AST_RETRIEVE_FLAG_ALL) { /* If we are showing list, no need do detailed */ | |||
There was a problem hiding this comment.
Since AST_RETRIEVE_FLAG_ALL is part of the sorcery ast_sorcery_retrieve_flags enum, you should probably adjust the changed prototypes or no one will know what flags are supported.
|
Could you use one of the existing fields in |
Good call. I'll look into that. |
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
|
This PR has been closed because it has been in "Changes Requested" or "submitter-action-required" state for more than 42 days. |
|
What's the process to re-open? |
|
I clicked the reopen button. |
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-passed
labels
|
Yaaaay, thanks. I don't think I have access to a reopen. I was looking for one. Updates coming asap! |
github-actions
bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
CLI 'pjsip show contact' does not show enough information.
One must telnet to AMI or write a script to ask Asterisk for example what the User-Agent is on a Contact
This feature adds the same details as PJSIPShowContacts to the CLI