feat: [say.c] Added language support for pashto and dari languages #368
Conversation
seanbright
changed the title
|
Yeah, i will review and do the required changes on coming weekend! |
@gtjoseph @InterLinked1 Pls review! |
|
Can you kindly merge this PR? @jcolp |
|
PRs require two people to review them before merging. That has not happened as of yet. |
|
Yeah, those two maintainers are not active, i guess. Anyway other way? |
|
It's not two specific people. It's two people in general. Community members, Sangoma employees, doesn't matter. Noone else has as of yet looked at this even from the community - probably because this is a seldom touched area and they don't know it. I can bring it up, but I have no time frame otherwise. |
| char fna[256] = ""; | ||
| int playWesht = 0; | ||
| if (!num) | ||
| return ast_say_digits_full(chan, 0, ints, language, audiofd, ctrlfd); |
There was a problem hiding this comment.
Per the coding guidelines, conditionals should always have braces in new code
|
|
||
| while (!res && num) { | ||
| /* The grammar for Pashto numbers is the same as for English except | ||
| * for the following: |
There was a problem hiding this comment.
The * should all be aligned, so these need to be indented one space.
| } else if (num < 1000) { | ||
| int hundreds = num / 100; | ||
| num = num % 100; | ||
| // 100: hundreds = 1, num = 0 |
There was a problem hiding this comment.
// C99 comments are not allowed. Use regular comments.
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
There was a problem hiding this comment.
There are still issues in this PR
- Address @InterLinked1's comments
- There aren't any "cherry-pick" comments.
- There should be an "Improvement" issue opened and both the commit message and the PR description should reference it.
See:
https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/
https://docs.asterisk.org/Development/Policies-and-Procedures/Commit-Messages/
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
|
You've got a merge commit now which must be removed. You'll need to rebase your branch off the current master and re-force-push. |
Ok i will clean it up. |
This pull request to add language support for Pashto and Dari in the mod_say module in asterisk is a great addition to the project. With this new feature, users who speak these languages can now benefit from the text-to-speech functionality provided by asterisk. This will make the platform more accessible and useful to a wider range of users, particularly those in regions where Pashto and Dari are spoken. This contribution will help to improve the overall usability and inclusivity of the asterisk platform.