Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func_groupcount.c: Adding Group Variables + additional Group functions #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

intellasoft
Copy link
Contributor

DumpGroups

  • New application. This will dump all channel group membership and associated
    variables

Groups and Group Variables

  • Group variables can be set on a group once the group is created
    When a group is destroyed, all variables on that group are also destroyed

    A group variable is somewhat like a global variable, but it's on a per-group
    basis.

    GroupSet - Adds functionality to the manager to be able to set a GROUP()
    on a channel.
    GroupsShowChannels - Show each channel and it's associated groups
    (a channel will be repeated for each group@category
    it's a member of)
    GroupsShowVariables - Show variables in each group@category, one event per
    group, all variables are contained in each
    group@category event
    GroupVarSet - Set a group variable (the group must already exist)
    GroupVarGet - Get a group variable

  • New Manager events:

    GroupCreate - Event is fired any time a group is made,
    ie: Set(GROUP=x) or Set(GROUP()=x@y).
    This event is only sent on when a channel is added to a group
    that did not exist previously.
    GroupChannelAdd - Event is fired any time a channel is added to a group
    GroupChannelRemove - Event is fired any time a channel is removed from a
    group
    GroupDestroy - Event is fired when there are no longer any channels assigned
    to the group
    GroupVarSet - Event is fired when any group variable is changed

  • New CLI Command

    group show variables

  • New Application

    DumpGroups() - Show groups and group assigments (similar to DumpChan)

Resolves: #291

@asterisk-org-access-app
Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

doc/CHANGES-staging/func_groupcount_group_variables.txt Outdated Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
main/cli.c Outdated Show resolved Hide resolved
main/cli.c Outdated Show resolved Hide resolved
@InterLinked1
Copy link
Contributor

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

@gtjoseph gtjoseph force-pushed the master branch 7 times, most recently from b15287c to 1862a36 Compare September 5, 2023 19:35
funcs/func_groupcount.c Outdated Show resolved Hide resolved
@intellasoft intellasoft force-pushed the master-issue-291 branch 3 times, most recently from 8610449 to 3f39fed Compare October 9, 2023 19:53
Copy link
Contributor

@InterLinked1 InterLinked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment:

funcs/func_groupcount.c Outdated Show resolved Hide resolved
@kobaz
Copy link

kobaz commented Oct 26, 2023

Whoops. I just realized my push was the same code. I forgot to 'git add'. This one should be all set.

main/cli.c Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
funcs/func_groupcount.c Outdated Show resolved Hide resolved
funcs/func_groupcount.c Show resolved Hide resolved
@kobaz
Copy link

kobaz commented Mar 18, 2024

multiple-commits: interim

DumpGroups
-------------------
* New application.  This will dump all channel group membership and associated
  variables

Groups and Group Variables
------------------
 * Group variables can be set on a group once the group is created
   When a group is destroyed, all variables on that group are also destroyed

   A group variable is somewhat like a global variable, but it's on a per-group
   basis.

   GroupSet - Adds functionality to the manager to be able to set a GROUP()
	      on a channel.
   GroupsShowChannels - Show each channel and it's associated groups
                        (a channel will be repeated for each group@category
                         it's a member of)
   GroupsShowVariables - Show variables in each group@category, one event per
                         group, all variables are contained in each
                         group@category event
   GroupVarSet - Set a group variable (the group must already exist)
   GroupVarGet - Get a group variable

 * New Manager events:
   ------------------
   GroupCreate - Event is fired any time a group is made,
                 ie: Set(GROUP=x) or Set(GROUP()=x@y).
                 This event is only sent on when a channel is added to a group
                 that did not exist previously.
   GroupChannelAdd - Event is fired any time a channel is added to a group
   GroupChannelRemove - Event is fired any time a channel is removed from a
                        group
   GroupDestroy - Event is fired when there are no longer any channels assigned
                  to the group
   GroupVarSet - Event is fired when any group variable is changed

 * New CLI Command
   ---------------
   group show variables

 * New Application
   ---------------
   DumpGroups() - Show groups and group assigments (similar to DumpChan)

Resolves: asterisk#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new-feature]: Group Variables
4 participants