Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm Management: port to Xandra db driver #771

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Annopaolo
Copy link
Collaborator

In the spirit of astarte-platform/astarte_data_access#60, replace the old and unmantained CQEx driver with Xandra.

@Annopaolo Annopaolo added the app:realm_management This issue or pull request is about astarte_realm_management application label Apr 6, 2023
@Annopaolo Annopaolo requested a review from rbino April 6, 2023 15:09
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #771 (4e876ab) into release-1.1 (e0fd426) will increase coverage by 1.47%.
Report is 12 commits behind head on release-1.1.
The diff coverage is 70.60%.

❗ Current head 4e876ab differs from pull request most recent head b6966d9. Consider uploading reports for the commit b6966d9 to get more accurate results

@@               Coverage Diff               @@
##           release-1.1     #771      +/-   ##
===============================================
+ Coverage        67.42%   68.90%   +1.47%     
===============================================
  Files              264      259       -5     
  Lines             6429     5994     -435     
===============================================
- Hits              4335     4130     -205     
+ Misses            2094     1864     -230     
Files Changed Coverage Δ
...anagement/lib/astarte_realm_management/c_system.ex 72.72% <0.00%> (-1.19%) ⬇️
..._management/lib/astarte_realm_management/config.ex 50.00% <ø> (-12.50%) ⬇️
...management/lib/astarte_realm_management/queries.ex 70.10% <69.30%> (+2.89%) ⬆️
..._management/lib/astarte_realm_management/engine.ex 82.94% <79.62%> (+4.48%) ⬆️
...e_realm_management/lib/astarte_realm_management.ex 100.00% <100.00%> (ø)

... and 124 files with indirect coverage changes

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Replace CQEx with Xandra in
database_test_helper, queries_test, engine_test.

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
@Annopaolo Annopaolo changed the base branch from release-1.1 to master August 2, 2023 11:17
@Annopaolo Annopaolo marked this pull request as ready for review August 4, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:realm_management This issue or pull request is about astarte_realm_management application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant