Experimental: allow custom prefetch_count on trigger policies #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on astarte-platform/astarte_core#83. |
Annopaolo
force-pushed
the
policy_prefetch_count
branch
from
2440650
to
8957d98
Compare
Annopaolo
changed the title
Annopaolo
added
enhancement
Annopaolo
force-pushed
the
policy_prefetch_count
branch
from
8957d98
to
33089f0
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.1 #749 +/- ##
===============================================
+ Coverage 68.43% 68.75% +0.32%
===============================================
Files 258 259 +1
Lines 5911 5924 +13
===============================================
+ Hits 4045 4073 +28
+ Misses 1866 1851 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Annopaolo
force-pushed
the
policy_prefetch_count
branch
from
33089f0
to
917b3ed
Compare
When using Trigger Delivery Policies, ordered event delivery is not guaranteed because messages might not be dequeued (thus processed) sequentially. As a possible solution, allow the policy to specify the AMQP consumer prefetch count used for its event queue. If the value is 1, an instance of Trigger Engine processes events sequentially. This is an experimental feature and thus disabled by default. You can enable it with the `REALM_MANAGEMENT_ALLOW_TRIGGER_POLICY_PREFETCH_COUNT` env var. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Until now, a trigger policy used a consumer prefetch set by the `TRIGGER_ENGINE_AMQP_CONSUMER_PREFETCH_COUNT` env (as usual in Astarte). If the policy provides a custom consumer prefetch count (e.g. for message ordering reasons), use that prefetch value. This can be done if the related Realm Management flag is enabled. The default policy will still respect the default prefetch count, so as not to break compatibility with previous Astarte versions. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
policy_prefetch_count
branch
from
917b3ed
to
47cb1ac
Compare
Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
policy_prefetch_count
branch
from
47cb1ac
to
6d7ab9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Trigger Delivery Policies, ordered event delivery is not guaranteed because messages might not be dequeued (thus processed) sequentially. Allow the policy to specify the AMQP consumer prefetch count used for its event queue. If the value is 1, the Trigger Engine instance processes events sequentially.
This is an experimental feature and thus disabled by default. You can enable it with the REALM_MANAGEMENT_ALLOW_AMQP_CONSUMER_PREFETCH_COUNT env var. Note that, even if the flag is enabled, the default policy will still respect the default prefetch count, so as not to break compatibility with previous Astarte versions.