Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add diagrams as code #592

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidebriani
Copy link
Collaborator

@davidebriani davidebriani commented Jun 1, 2021

Add pipeline to generate images from diagrams-as-code.

The diagrams are written as code using the D2 Language and compiled into images using the relative tooling so they can be used within documentation pages.

Generated images:

astarte-architecture.svg

astarte-architecture

astarte-pairing-registration.svg

astarte-pairing-registration

astarte-pairing-authentication.svg

astarte-pairing-authentication

@davidebriani davidebriani added the documentation This issue or pull request is about documentation label Jun 1, 2021
@davidebriani davidebriani requested a review from bettio June 1, 2021 09:12
@davidebriani davidebriani force-pushed the docs/add-diagrams-as-code branch 3 times, most recently from 98534e7 to 77a07a2 Compare June 7, 2021 16:46
@atsetilam
Copy link
Contributor

I think text readability should be improved; maybe making it bold and setting a bigger font size might help?

@davidebriani davidebriani changed the base branch from release-1.0 to master December 13, 2023 15:19
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f142539) 68.32% compared to head (498a173) 68.32%.
Report is 11 commits behind head on master.

❗ Current head 498a173 differs from pull request most recent head 437eac9. Consider uploading reports for the commit 437eac9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   68.32%   68.32%           
=======================================
  Files         270      270           
  Lines        6986     6986           
=======================================
  Hits         4773     4773           
  Misses       2213     2213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add some initial diagrams:
- An overview of the Astarte architecture and how it connects with
external services.
- A basic sequence diagram describing the process of device
registration.
- A basic sequence diagram describing the process of device
authentication.

Signed-off-by: Davide Briani <davide.briani@secomind.com>
Using the D2 Language tooling, define a CI step that compiles the code
of the diagrams into images that can be used for documentation purposes
and referenced by documentation pages.

Signed-off-by: Davide Briani <davide.briani@secomind.com>
Add references to the generated images on appropriate documentation
pages, so that diagrams are displayed alongside textual explanations.

Signed-off-by: Davide Briani <davide.briani@secomind.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request is about documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants