Replace deprecated utcnow() by now()

[J535D165]

No description provided.

[J535D165]

Help is welcome to fix the broken tests. It's not directly clear to me how to resolve this.

[jteijema]

I think token_created_at changes from offset-aware to offset-naive (somewhere?) and fails. Maybe it's converted somewhere in the database.

    def token_valid(self, provided_token, max_hours=24):
        """Checks whether provided token is correct and still valid"""
        # there must be a token and a timestamp
        if bool(self.token) and bool(self.token_created_at):
            now = dt.datetime.now(dt.timezone.utc)
            diff = (now - self.token_created_at).total_seconds()
            # return if token is correct and we are still before deadline
            return self.token == provided_token and diff <= max_hours * 3600
        else:
            return False

Because usually this will work fine, but for some reason self.token_created_at is converted from offset-aware to offset-native.

[jteijema]

def test_token_validity(setup_teardown, subtract_time):
    subtract_hours, subtract_mins, validity = subtract_time
    user = crud.create_user(DB)
    user.set_token_data("secret", "salt")
    assert user.token_created_at.tzinfo is not None and user.token_created_at.tzinfo.utcoffset(user.token_created_at) is not None, "token_created_at must be offset-aware. Location 1"
    DB.session.commit()
    assert user.token_created_at.tzinfo is not None and user.token_created_at.tzinfo.utcoffset(user.token_created_at) is not None, "token_created_at must be offset-aware. Location 2"

FAILED asreview/webapp/tests/test_database_and_models/test_user_model.py::test_token_validity[subtract_time0] - AssertionError: token_created_at must be offset-aware. Location 2
FAILED asreview/webapp/tests/test_database_and_models/test_user_model.py::test_token_validity[subtract_time1] - AssertionError: token_created_at must be offset-aware. Location 2
FAILED asreview/webapp/tests/test_database_and_models/test_user_model.py::test_token_validity[subtract_time2] - AssertionError: token_created_at must be offset-aware. Location 2
FAILED asreview/webapp/tests/test_database_and_models/test_user_model.py::test_token_validity[subtract_time3] - AssertionError: token_created_at must be offset-aware. Location 2

---

So I think the database is stripping the timezone information.

[jteijema]

    def token_valid(self, provided_token, max_hours=24):
        """Checks whether provided token is correct and still valid"""
        # there must be a token and a timestamp
        if bool(self.token) and bool(self.token_created_at):
            now = dt.datetime.now(dt.timezone.utc)
            if self.token_created_at.tzinfo is None:
                self.token_created_at = self.token_created_at.replace(tzinfo=dt.timezone.utc)
            diff = (now - self.token_created_at).total_seconds()
            # return if token is correct and we are still before deadline
            return self.token == provided_token and diff <= max_hours * 3600
        else:
            return False

Adding self.token_created_at = self.token_created_at.replace(tzinfo=dt.timezone.utc) in models.py will fix all 8 failing test, but that doesn't solve the issue. Can't guarantee there aren't timezone issues now.

[jteijema]

token_created_at = Column(DateTime(timezone=True)) sadly doesn't do the trick.

[jteijema]

An alternative could be to keep using offset native datetimes, by using datetime.datetime.now(datetime.timezone.utc).replace(tzinfo=None), however, this is discouraged.

>>> datetime.datetime.utcnow() - datetime.datetime.now(datetime.timezone.utc).replace(tzinfo=None)
datetime.timedelta(0)

[jteijema]

Note that if you are using Python 3.11 or newer, you can replace datetime.timezone.utc with a shorter datetime.UTC.