Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typings #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix typings #166

wants to merge 2 commits into from

Conversation

rogierschouten
Copy link

@rogierschouten rogierschouten commented Oct 2, 2017

TypeScript typings no longer worked somehow, this works.

@rogierschouten
Copy link
Author

Fixed conflict with master

@ashtuchkin
Copy link
Owner

Current version works for me and other people. Did you happen to investigate why it doesn't work for you?

We also need to include some testing, otherwise it's hard to see if this actually works.

@rogierschouten
Copy link
Author

rogierschouten commented Jun 4, 2018 via email

@zheeeng
Copy link

zheeeng commented Sep 30, 2021

@ashtuchkin In somehow I have to import iconv-lite from node_modules or other not icon-vite path. e.g.:

import * as iconv from './node_modules/iconv-lite';

its type dosn't have decode, encode, encodingExists, decodeStream, encodeStream, getEncoder, getDecoder, which are defined under fixed module name iconv-lite.

This type file requires importing by statement:

import * as iconv-lite from 'iconv-lite'

I support this commitment, but I have to fork a workaround repo at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants