Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several small adjustments #242

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Several small adjustments #242

merged 9 commits into from
Oct 12, 2023

Conversation

crizzitello
Copy link
Contributor

@crizzitello crizzitello commented Oct 4, 2023 •
edited

  • Make HotKeyManager a singleton
  • Fix the Windows default commands for area and window capture
  • New bool SystemHelpers::isLightMode() method
  • Use fusion style on windows
  • Further simplify the SingleStrokeKeySequenceEdit
  • We are using new features from Qt 6.5 so we now Require Qt 6.5+ to build
  • Unify all default shortcuts to Meta+Alt+<key> this is Command+Option+<key> on Mac os
  • Fix on Mac os Command and Control were mapped backwards. Meta is the Control key on Mac and Ctrl is the Command Key

@crizzitello crizzitello force-pushed the singletonHotkeys branch 4 times, most recently from 8e75262 to 9ace452 Compare October 4, 2023 15:50
JoelAtDeluxe
JoelAtDeluxe reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@JoelAtDeluxe JoelAtDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the isDarkMode isLightTheme helper.
I didn't test anything though. :)

@crizzitello crizzitello mentioned this pull request Oct 4, 2023
Merged
@crizzitello crizzitello force-pushed the singletonHotkeys branch 4 times, most recently from c138d55 to 3818ea1 Compare October 5, 2023 15:28
@jkennedyvz jkennedyvz merged commit 3e1ba34 into ashirt-ops:main Oct 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkennedyvz jkennedyvz jkennedyvz approved these changes

@jrozner jrozner Awaiting requested review from jrozner jrozner is a code owner

@JoelAtDeluxe JoelAtDeluxe Awaiting requested review from JoelAtDeluxe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crizzitello @JoelAtDeluxe @jkennedyvz