Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key selector #238

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Fix key selector #238

merged 3 commits into from
Oct 3, 2023

Conversation

crizzitello
Copy link
Contributor

@crizzitello crizzitello commented Oct 3, 2023 •
edited

Changes to the SingleStrokeKeySequenceEditor

  • Emit keySequenceChange when its changed
  • Show the clear button for the control
  • remove the event filter to clear the key on enter

Changes to Settings Dialog

  • Update Settings Dialog to remove the clear settings button
  • Update Settings Dialog to Use Server URL and place it above the api key lines

Changes to AppConfig

  • Allow Shortcuts to be empty and default is never set.

@crizzitello crizzitello mentioned this pull request Oct 3, 2023
Merged
@jkennedyvz jkennedyvz merged commit b170e87 into ashirt-ops:main Oct 3, 2023
5 checks passed
@crizzitello crizzitello deleted the fixKeySelector branch October 3, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkennedyvz jkennedyvz jkennedyvz approved these changes

@jrozner jrozner Awaiting requested review from jrozner jrozner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crizzitello @jkennedyvz