Netman testing #236
Merged
Netman testing #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crizzitello
force-pushed
the
netmanTesting
branch
from
9a94a81
to
f8ad850
Compare
| return; | ||
| } | ||
|
|
||
| (*reply)->isFinished() ? (*reply)->close() : (*reply)->abort(); |
There was a problem hiding this comment.
Yeah, that's clearly better.
crizzitello
force-pushed
the
netmanTesting
branch
from
f8ad850
to
850fa97
Compare
crizzitello
force-pushed
the
netmanTesting
branch
from
850fa97
to
2a08b9d
Compare
jkennedyvz
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr does two things
stopReplyandtidyReplyintocleanUpReply