New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topaz configuration document #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4811526512
💛 - Coveralls |
carabasdaniel
force-pushed
the
config-doc
branch
from
April 21, 2023 12:07
9553ac8
to
96aed31
Compare
carabasdaniel
force-pushed
the
config-doc
branch
from
April 24, 2023 08:50
bd70cee
to
25cb8d7
Compare
ogazitt
requested changes
Apr 24, 2023
I suggest we add an explicit paragraph on using environment variables inside the config file. Right now, we only show using ${TOPAZ_DIR}, but it does not get explained in terms of behavior. For example, what happens when the env variable is not existing? It will return an empty string., effectively making it a NOP. |
Added a bit more info on local vs remote directory
ogazitt
previously approved these changes
Apr 25, 2023
carabasdaniel
force-pushed
the
config-doc
branch
from
April 26, 2023 14:37
4abbb0d
to
8316729
Compare
gertd
previously approved these changes
Apr 26, 2023
carabasdaniel
force-pushed
the
config-doc
branch
from
April 26, 2023 17:18
8316729
to
e4925ac
Compare
ogazitt
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #75