[DO NOT MERGE] Remote directory 0.21 (disable edge-ds) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronenh
commented
Apr 11, 2023
|
|
||
| type Config struct { | ||
| EdgeConfig directory.Config `json:"edge"` | ||
| Remote struct { | ||
| EdgeConfig struct { |
There was a problem hiding this comment.
Note: This is a copy of the definition from go-edge-ds to eliminate the import.
|
|
||
| e.Server.RegisterServer("edgeDirServer", edge.Start, edge.Stop) | ||
| } | ||
| // if (strings.Contains(e.Configuration.Directory.Remote.Addr, "localhost") || strings.Contains(e.Configuration.Directory.Remote.Addr, "0.0.0.0")) && |
There was a problem hiding this comment.
Note: Temporarily disabling the local edge server.
It now returns the key of the user, not the id
|
Replaced by #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches topaz to pb-directory 0.21.
The dependency on go-edge-ds is temporarily removed until a versions compatible with 0.21 is available.