Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named configurations #255

Merged
merged 73 commits into from Apr 23, 2024
Merged

Add named configurations #255

merged 73 commits into from Apr 23, 2024

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel commented Jan 23, 2024

Depends on #256

Copy link

github-actions bot commented Jan 23, 2024

Pull Request Test Coverage Report for Build 8740812037

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 123 (6.5%) changed or added relevant lines in 9 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 23.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cc/config/config.go 1 3 33.33%
pkg/cc/config/helper.go 0 2 0.0%
pkg/cli/cc/dir.go 1 4 25.0%
pkg/cli/cc/container.go 0 5 0.0%
pkg/cc/config/loader.go 3 14 21.43%
pkg/cli/dockerx/docker.go 0 20 0.0%
pkg/cc/config/generator.go 0 24 0.0%
pkg/cli/cc/cc.go 0 48 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cli/cc/dir.go 4 65.0%
pkg/app/topaz.go 17 50.0%
Totals Coverage Status
Change from base Build 8660326558: -0.7%
Covered Lines: 1132
Relevant Lines: 4859

💛 - Coveralls

@carabasdaniel carabasdaniel force-pushed the named_configurations branch 4 times, most recently from af2e1bd to 8a08c8b Compare January 31, 2024 10:12
@carabasdaniel carabasdaniel marked this pull request as ready for review January 31, 2024 10:13
@carabasdaniel carabasdaniel changed the base branch from main to model-v2 February 2, 2024 13:56
BogdanIrimie
BogdanIrimie previously approved these changes Feb 9, 2024
cmd/topaz/main.go Outdated Show resolved Hide resolved
pkg/app/topaz.go Outdated Show resolved Hide resolved
pkg/cli/cc/cc.go Outdated Show resolved Hide resolved
pkg/cli/cmd/configure.go Outdated Show resolved Hide resolved
ronenh
ronenh previously approved these changes Feb 28, 2024
@carabasdaniel carabasdaniel force-pushed the named_configurations branch 3 times, most recently from 839e79f to dfc63e5 Compare March 6, 2024 09:28
@carabasdaniel carabasdaniel force-pushed the named_configurations branch 4 times, most recently from 05de314 to 9ddcf10 Compare March 13, 2024 15:17
@gertd gertd merged commit e7daf2c into main Apr 23, 2024
5 checks passed
@gertd gertd deleted the named_configurations branch April 23, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants