-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nushell plugin list all (#1501) #1502
Conversation
@acidghost can you add a regression test to https://github.com/asdf-vm/asdf/blob/master/test/asdf_nu.bats ? |
What should it test? Check that the output of |
It should test the permutations of this regex you're changing to ensure that the command runs successfully for expected repositories. |
@jthegedus I think this is what you meant. To fully test this, there should be more types of test repository URLs (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Yeah, just submit a follow up with some more test cases. There's probably a way to hack more values into just this test case. |
Summary
Fixes #1501.