Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nushell plugin list all (#1501) #1502

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

acidghost
Copy link
Contributor

Summary

Fixes #1501.

@acidghost acidghost requested a review from a team as a code owner March 16, 2023 08:56
@jthegedus
Copy link
Contributor

@acidghost can you add a regression test to https://github.com/asdf-vm/asdf/blob/master/test/asdf_nu.bats ?

@acidghost
Copy link
Contributor Author

What should it test? Check that the output of asdf plugin list all is the same for Nushell and bash in terms of repositories?

@jthegedus
Copy link
Contributor

It should test the permutations of this regex you're changing to ensure that the command runs successfully for expected repositories.

test/asdf_nu.bats Outdated Show resolved Hide resolved
@acidghost
Copy link
Contributor Author

@jthegedus I think this is what you meant. To fully test this, there should be more types of test repository URLs (e.g. https, git, etc.). I can add these in another PR as it would require to modify most of the test cases to update the expected values.

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jthegedus
Copy link
Contributor

@jthegedus I think this is what you meant. To fully test this, there should be more types of test repository URLs (e.g. https, git, etc.). I can add these in another PR as it would require to modify most of the test cases to update the expected values.

Yeah, just submit a follow up with some more test cases. There's probably a way to hack more values into just this test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nushell asdf plugin list all does not list all plugins
2 participants