Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local plugin in then clause too #1202

Closed
wants to merge 1 commit into from
Closed

local plugin in then clause too #1202

wants to merge 1 commit into from

Conversation

znz
Copy link
Contributor

@znz znz commented Apr 12, 2022

Summary

I think plugin variable should be local not only in else clause but then clause too.

@znz znz requested a review from a team as a code owner April 12, 2022 09:10
@Stratus3D
Copy link
Member

Thanks for the PR @znz ! These changes look good, however the commit is failing the conventional commit check (https://github.com/asdf-vm/asdf/runs/5987076283?check_suite_focus=true). See https://www.conventionalcommits.org/en/v1.0.0/ for proper formatting. If you are unable to amend your comment message let me know and I can amend it for you.

@Stratus3D
Copy link
Member

Closed in favor of #1203

@Stratus3D Stratus3D closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants