feat(elvish)!: remove deprecated syntax for Elvish v0.17.0 #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherryblossom000
changed the title
Use new
- assignment syntax (legacy `foo = bar` instead of `var foo = bar` or `set foo = bar` deprecated in v0.15.0)
- slice syntax (legacy `a:b` instead of `a..b` deprecated in v0.15.0)
- lambda syntax (legacy `[args]{ body }` instead of `{|args| body }` deprecated in v0.17.0)
BREAKING CHANGE: Drops support for Elvish versions prior to v0.17.0 due
to the new lambda syntax.
This commit stops this error: ``` ~> asdf Exception: arity mismatch: arguments must be 1 or more values, but is 0 values ```
- Use [tilde expansion][1] instead of `$E:HOME` - Set `asdf~` variable instead of creating a `fn asdf` and explicitly passing arguments (see [docs on the `~` variable suffix][2]) - Use some destructuring in the `asdf` function using a [rest variable][3] [1]: https://elv.sh/ref/language.html#tilde-expansion [2]: https://elv.sh/ref/language.html#variable-suffix [3]: https://elv.sh/ref/language.html#var
More details: https://elv.sh/ref/command.html#rc-file I haven't properly updated the Chinese docs for Getting Started as I don't know Chinese. For now, I just replaced `~/.elvish/rc.elv` with `~/.config/elvish/rc.elv`.
cherryblossom000
changed the title
|
This looks like a duplicate of #1159. Is it not? |
|
Oops, it is. Sorry, I forgot to check if there was a already an existing PR! |
|
@cherryblossom000 if you want to help review the code changes on #1159 that would be great! I'm not a elvish shell user. I am planning on reviewing that PR tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some fixes and improvements for the Elvish support.
asdfwith no arguments. Previously, this would happen:set-env ASDF_DIR (brew --prefix asdf)/libexec; set-env ASDF_DATA_DIR ~/.asdfto therc.elvfor Homebrew (the Elvish script setsASDF_DIRto~/.asdfby default andASDF_DATA_DIRtoASDF_DIR, which is incorrect for Homebrew installations)$XDG_CONFIG_HOMEon Unix and%AppData%on Windows, so I linked to the docs and used~/.config/elvish/rc.elvin the installation script. I haven't updated the Chinese docs properly as I don't know Chinese and instead replaced~/.elvish/rc.elvwith~/.config/elvish/rc.elvwithout the link to the Elvish docs.These are some more subjective and minor changes as well (please let me know I should undo the commit):
$E:HOMEasdf~variable instead of creating afn asdfand explicitly passing arguments (see docs on the~variable suffix)asdffunction using a rest variableOther Information
Sorry if this PR does too many things at once; I just noticed a few things I could improve with the Elvish support when updating it to work for the latest Elvish version. I'm very happy to split up this PR into smaller ones.