Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regex validate plugin names on plugin add cmd #1010

Merged
merged 9 commits into from Jul 29, 2021
Merged

fix: regex validate plugin names on plugin add cmd #1010

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b32da57
fix: mock plugin support any fixture plugin
jthegedus Jul 25, 2021
1895c14
fix: plugin update test cases
jthegedus Jul 25, 2021
27f03fd
fix: plugin update test cases
jthegedus Jul 25, 2021
bf26ac1
fix: revert prior changes
jthegedus Jul 25, 2021
86c4164
fix: plugin add regex validation
jthegedus Jul 25, 2021
7e796d1
fix: rm unnecessary fixtures
jthegedus Jul 25, 2021
2a16c48
fix: quiet grep
jthegedus Jul 25, 2021
4e1e13f
fix: rename plugin-add to plugin add in tests
jthegedus Jul 25, 2021
a74a535
chore: rename plugin-add to plugin add elsewhere
jthegedus Jul 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/plugin_update_command.bats
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ teardown() {
}

@test "asdf plugin-update should pull latest default branch (refs/remotes/origin/HEAD) for plugin even if default branch changes" {
install_mock_plugin_repo "dummy-remote"
install_mock_plugin_repo "dummy"
remote_dir="$BASE_DIR/repo-dummy-remote"
# set HEAD to refs/head/main in dummy-remote
git -C "${remote_dir}" checkout -b main
Expand All @@ -39,7 +39,7 @@ teardown() {
}

@test "asdf plugin-update should pull latest default branch (refs/remotes/origin/HEAD) for plugin even if the default branch contains a forward slash" {
install_mock_plugin_repo "dummy-remote"
install_mock_plugin_repo "dummy"
remote_dir="$BASE_DIR/repo-dummy-remote"
# set HEAD to refs/head/my/default in dummy-remote
git -C "${remote_dir}" checkout -b my/default
Expand All @@ -62,7 +62,7 @@ teardown() {
run asdf plugin-update dummy "${current_sha}"

# setup mock plugin remote
install_mock_plugin_repo "dummy-remote"
install_mock_plugin_repo "dummy"
remote_dir="$BASE_DIR/repo-dummy-remote"
# set HEAD to refs/head/main in dummy-remote
git -C "${remote_dir}" checkout -b main
Expand Down
2 changes: 1 addition & 1 deletion test/test_helpers.bash
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@ install_mock_broken_plugin() {
install_mock_plugin_repo() {
local plugin_name=$1
local location="${BASE_DIR}/repo-${plugin_name}"
cp -r "$BATS_TEST_DIRNAME/fixtures/dummy_plugin" "${location}"
jthegedus marked this conversation as resolved.
Show resolved Hide resolved
cp -r "$BATS_TEST_DIRNAME/fixtures/${plugin_name}_plugin" "${location}"
git -C "${location}" init -q
git -C "${location}" config user.name "Test"
git -C "${location}" config user.email "test@example.com"
Expand Down