fix: Use more idiomatic fish #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `.` is deprecated in fish, unlike POSIX shells. We can avoid calling `psub` and pipe directly into source which does the same thing. https://fishshell.com/docs/current/cmds/source.html
|
I've added a comment in the test that failed, which forbids |
|
@danhper you are familiar with Fish right? Can you take a look at these changes? Thanks for the PR @maxnordlund , changes look good to me but I'm not familiar with Fish. |
jthegedus
reviewed
Sep 9, 2021
|
I think we should merge and those testing with |
Stratus3D
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The use of
.is deprecated in fish, unlike POSIX shells. We can avoid callingpsuband pipe directly into source which does the same thing.Other Information
See https://fishshell.com/docs/current/cmds/source.html