fix: Use more idiomatic fish (#1042)

The use of `.` is deprecated in fish, unlike POSIX shells. We can avoid calling `psub` and pipe directly into source which does the same thing. https://fishshell.com/docs/current/cmds/source.html
asdf-vm · Oct 7, 2021 · 847ec73 · 847ec73
1 parent 8a515f4
commit 847ec73
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/asdf.fish b/lib/asdf.fish
@@ -7,7 +7,7 @@ function asdf
     switch "$command"
         case "shell"
             # source commands that need to export variables
-            . (asdf export-shell-version fish $argv | psub)
+            command asdf export-shell-version fish $argv | source # asdf_allow: source
         case '*'
             # forward other commands to asdf script
             command asdf "$command" $argv

diff --git a/test/banned_commands.bats b/test/banned_commands.bats
@@ -26,6 +26,7 @@ banned_commands=(
     "sort.*-V"
     "sort.*--sort-versions"
     # source isn't POSIX compliant. . behaves the same and is POSIX compliant
+    # Except in fish, where . is deprecated, and will be removed in the future.
     source
 )