refactor: extract duplicated latest version logic to function

asdf-vm · Nov 24, 2023 · ff65727 · ff65727
1 parent a28ca31
commit ff65727
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/lib/functions/versions.bash b/lib/functions/versions.bash
@@ -155,17 +155,13 @@ latest_command() {
       exit 1
     fi
   else
-    # pattern from xxenv-latest (https://github.com/momo-lab/xxenv-latest)
-    versions=$(list_all_command "$plugin_name" "$query" |
-      grep -ivE "(^Available versions:|-src|-dev|-latest|-stm|[-\\.]rc|-milestone|-alpha|-beta|[-\\.]pre|-next|(a|b|c)[0-9]+|snapshot|master)" |
-      sed 's/^[[:space:]]\+//' |
-      tail -1)
-    if [ -z "${versions}" ]; then
+    version=$(_latest_version_helper "$plugin_name" "$query")
+    if [ -z "${version}" ]; then
       exit 1
     fi
   fi
 
-  printf "%s\n" "$versions"
+  printf "%s\n" "$version"
 }
 
 latest_all() {
@@ -186,11 +182,7 @@ latest_all() {
           version="unknown"
         fi
       else
-        # pattern from xxenv-latest (https://github.com/momo-lab/xxenv-latest)
-        version=$(list_all_command "$plugin_name" |
-          grep -ivE "(^Available version:|-src|-dev|-latest|-stm|[-\\.]rc|-alpha|-beta|[-\\.]pre|-next|(a|b|c)[0-9]+|snapshot|master)" |
-          sed 's/^[[:space:]]\+//' |
-          tail -1)
+        version=$(_latest_version_helper "$plugin_name")
         if [ -z "${version}" ]; then
           version="unknown"
         fi
@@ -238,3 +230,11 @@ local_command() {
     version_command local "$@"
   fi
 }
+
+_latest_version_helper() {
+  # pattern from xxenv-latest (https://github.com/momo-lab/xxenv-latest/blob/fe8fb00d55d2fb8daca834214f7ac614f87c255f/bin/xxenv-latest#L85)
+  list_all_command "$@" |
+    grep -ivE "(^Available versions?:|-src|-dev|-latest|-stm|[-\\.]rc|-alpha|-beta|[-\\.]pre|-next|(a|b|c)[0-9]+$|snapshot|master|-nightly)" |
+    sed 's/^[[:space:]]\+//' |
+    tail -1
+}