fix: ensure shims get created when data dir has spaces

asdf-vm · Jul 14, 2021 · 8ce338a · 8ce338a
1 parent 60e0e05
commit 8ce338a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/lib/commands/command-reshim.bash b/lib/commands/command-reshim.bash
@@ -103,9 +103,12 @@ generate_shim_for_executable() {
 generate_shims_for_version() {
   local plugin_name=$1
   local full_version=$2
-  for executable_path in $(plugin_executables "$plugin_name" "$full_version"); do
+  local executable_path
+  local all_plugin_executables
+  all_plugin_executables="$(plugin_executables "$plugin_name" "$full_version")"
+  while read -r executable_path; do
     write_shim_script "$plugin_name" "$full_version" "$executable_path"
-  done
+  done <<< "${all_plugin_executables}"
 }
 
 remove_obsolete_shims() {

diff --git a/lib/utils.bash b/lib/utils.bash
@@ -576,13 +576,15 @@ with_plugin_env() {
 plugin_executables() {
   local plugin_name=$1
   local full_version=$2
-  for bin_path in $(list_plugin_exec_paths "$plugin_name" "$full_version"); do
+  local bin_path all_bin_paths
+  all_bin_paths="$(list_plugin_exec_paths "$plugin_name" "$full_version")"
+  while read -r bin_path; do
     for executable_file in "$bin_path"/*; do
       if is_executable "$executable_file"; then
         printf "%s\\n" "$executable_file"
       fi
     done
-  done
+  done <<< "${all_bin_paths}"
 }
 
 is_executable() {