fix bug where a dict with an id causes contained refs to fail to resolve #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
fix_ref_in_id
branch
from
f7dc3f4
to
4c62c4d
Compare
This was referenced Dec 21, 2023
Draft
braingram
force-pushed
the
fix_ref_in_id
branch
from
4c62c4d
to
bdb9eb4
Compare
braingram
force-pushed
the
fix_ref_in_id
branch
2 times, most recently
from
905f81b
to
71fdc70
Compare
|
The 2 downstream failures are unrelated to this PR and are addressed in: #1785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove use of
json_idinfind_referencescallback passed towalk_and_modify.The
json_idargument (which stores the most recently encountered 'id' value) is primarily (perhaps only) useful for schema parsing. However,find_references(called on the ASDF tree) uses thejson_idvalue to construct the uri for the referred object. I see no reference to this behavior in:https://datatracker.ietf.org/doc/html/rfc6901
https://datatracker.ietf.org/doc/html/draft-pbryan-zyp-json-ref-03
https://datatracker.ietf.org/doc/html/rfc3986
and this can lead to reference resolution failure (see #1715).
Fixes #1715
Checklist: