This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast contains unwanted exit command #34
Comments
When releasing 2.0 I was aware of this regression, but didn't want to block release because of it. But now is a good time to discuss it. This is your shell printing The previous version of asciinema kept whole recording in memory before saving it to file, and it was easy to detect "exit" in the last recorded frame and throw it away (because asciinema knew it's the last frame). With new version came new file format, which is more real-time, streaming friendly, and it writes to disk in real-time. Due to this when the recording session finishes the "exit" has already been written to a file. And we can't just throw away any "exit" printed to a terminal, we can only remove the final one, because you could have nested bash sessions and this "exit" can be useful information for someone watching that you exited the inner shell. There are several potential solutions for this:
In general I prefer to not modify the source data when recording (change text, change timing, remove frames). Removing final "exit" is removing data from the stream, however it's not something the user really wants so it's fine for me to get rid of it. Solution 2. seems the simplest to me at the moment. |
Thanks for your explanation. I have seen casts were people are using |
Any updates on this? I'm facing the same issue. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hello,
I wondered why an
exit
is printed after pressingCTRL + D
to finish the cast usingrec
.A cast generated by asciinema 1.x.x looks fine - I would like to get rid of it again.
Before
After
The text was updated successfully, but these errors were encountered: