Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage videos (Fix #17) #18

Merged
merged 5 commits into from Oct 4, 2018
Merged

Conversation

double-fault
Copy link
Contributor

No description provided.

@double-fault
Copy link
Contributor Author

Hmm, looks like the videos are not previewing on the README page. Hold on, please.

@double-fault
Copy link
Contributor Author

Seems to preview now! I've added two asciicasts.

@double-fault double-fault changed the title Add usage videos (Fix #21) Add usage videos (Fix #17) Oct 2, 2018
@GhostofGoes
Copy link
Owner

A few things. For the first video, the --version flag is redundant, and I'd rather it show usage of at least a few of the other arguments that do matter (-n for hosts and -i for interfaces). Two commands you could run would be get-mac -n 192.168.0.1 (replace IP with your Router's IP) and get-mac -i eth0 (or another interface on your machine).

Don't include the "exit" command in either video.

For the second video: Same as the first, show example of a remote host and a local interface.

@komish komish mentioned this pull request Oct 3, 2018
@double-fault
Copy link
Contributor Author

@GhostofGoes Sure, I'll do that! I'm slightly busy today with life, I'll be sure to make the new videos tomorrow.

@double-fault
Copy link
Contributor Author

@GhostofGoes I've made the changes you've asked for. Although, the "exit" command in the recording seems to be a bug with asciinema (asciinema/discussions#34), and I could not remove it. I tried out some more tools like ttystudio and showterm, but none of them worked for me.

@GhostofGoes
Copy link
Owner

Oh, this is awesome! Thank you so much 😄

@GhostofGoes GhostofGoes merged commit 9a0e7ab into GhostofGoes:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants