Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme, color mode and Linux platform version to tags reported to Sentry (#660) #1329

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vcvitaly
Copy link

@vcvitaly vcvitaly commented Apr 14, 2023

Closes #660

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Other, please describe:

Does this PR introduce a breaking change?

  • No
  • Yes

Checklist:

  • I have updated the documentation to reflect the changes introduced by this PR.

Creating the pull request triggers some automated tests.
See the chapter building in the contributor's guide to find out how to run them on your local machine.

@ahus1
Copy link
Contributor

ahus1 commented Apr 16, 2023

Thank you for this pull request - the result looks great.

I see that you added a 3rd party dependency. As I like to keep the dependencies of this plugin at a minimum, please use the information available from com.intellij.openapi.util.SystemInfo, com.intellij.openapi.util.SystemInfoRt or system properties (like for example System.getProperty("os.name") or System.getProperty("os.version"))

One addition to "light mode": Light mode has two meanings in Intellij: "light" as in "light and dark" and "light" as in "light edit mode" and "full edit mode". You can use the code snippet LightEdit.owns(project) to determine this. See https://www.jetbrains.com/help/idea/lightedit-mode.html for more information about the light edit mode.

@vcvitaly
Copy link
Author

vcvitaly commented Apr 18, 2023

Hi @ahus1
Thanks for the explanation about the edit mode, I will fix it.

As for the external dependency - at moment none of SystemInfo, SystemInfoRt or system properties provide information about Linux distro name and version. This dependency jar only weights 11Kb, is it still an issue? If so, can I manually copy the util file I need into the project, would that be and approprivate solution?

@ahus1
Copy link
Contributor

ahus1 commented Apr 18, 2023

Hi, if the jetbrains platform functions don't provide this information, and if it is also not available as a system property, then please skip this part of the information. Don't use the library as it is another dependency that needs to be maintained updated. Also don't copy over the code, as I don't want to maintain it.

@vcvitaly vcvitaly force-pushed the 660-report-additional-context-information-via-sentry branch from 6650180 to a832478 Compare July 4, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report additional context information via Sentry
2 participants