Code quality - drop while(true) #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayowel
commented
Jul 19, 2021
| } | ||
| } else { | ||
| break; | ||
| while (Objects.nonNull(currentParent)) { |
There was a problem hiding this comment.
Maybe this should be replaced by
for (Path currentParent = optional.get(); Objects.nonNull(currentParent); currentParent = currentParent.getParent())
|
Updated the while loop to a for in Also removed the class' constructor as well as some attributes that were not used. Dropped a lambda instantiation as the raw value it returned could be used instead and avoided the use of a stream to create a list where the list could directly be instantiated instead. |
Ayowel
commented
Aug 14, 2021
| } else if (kind == ENTRY_MODIFY && event.count() > 1) { | ||
| watchKey.reset(); | ||
| } else { | ||
| } else if (kind != ENTRY_MODIFY || (kind == ENTRY_MODIFY && event.count() == 0)) { |
There was a problem hiding this comment.
FIXME: should be && event.count() <= 1
| @@ -118,6 +120,7 @@ private void watchPathChanges() { | |||
| } | |||
|
|
|||
| List<WatchEvent<?>> watchEvents = watchKey.pollEvents(); | |||
There was a problem hiding this comment.
pollEvents is not blocking, might want to add a sleep somewhere in here or use a self-scheduling method instead of a loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #524 and added comments on the loops where a
while(true)seemed legitimate to justify them.Note that:
FileBrowseServiceImpl.searchDownAndSelect, I replaced the use of previous by next inif (Objects.isNull(searchFoundItem))as I could not make sense of the code the way it was.Other than that, old and new code should be strictly equivalent