Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include major in go.mod module directive #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nightah
Copy link

@nightah nightah commented Sep 2, 2021

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This change includes the major version in the module path.
This will ensure appropriate semver tagging.

Closes #384.

This change includes the major version in the module path.
This will ensure appropriate semver tagging.
Copy link

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to have this merged.

@marclop
Copy link

marclop commented Sep 13, 2021

@asaskevich any reason not to update the go.mod file to make it compatible with Go modules?

@sergeyglazyrindev
Copy link

Hello guys!
I forked this package cause owner disappeared. Hope, he will be back, but it would be easier to merge these changes back if he is back
Link to my repo: create issue there and we'll discuss it.

@tboerger
Copy link

It would be great to get this merged, currently renovate seems to be not able to update the dependency automatically because of the go.mod definition :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the release tags version go mod compatible.
4 participants