Windows REPL + LineNoise #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drkameleon
added
bug
github-actions
bot
added
helpers
…tomatically being built)
…epl-linenoise-and-windows # Conflicts: # version/build
|
Related: antirez/linenoise#113 It seems like there is a consistent issue when the library is built on Windows (many UNIX-specific headers missing: Also see: https://github.com/msteveb/linenoise (Possible solution❓ Claims to offer Win support) |
github-actions
bot
added
workflows
…epl-linenoise-and-windows # Conflicts: # .github/workflows/release.yml # .github/workflows/windows.yml # version/build
github-actions
bot
removed
the
workflows
…t shows fine, even for MSYS2
github-actions
bot
added
3rd-party
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Arturo's REPL on Windows leaves much to be desired. It should generally behave like the Mac/*nix versions.
This is mainly because the LineNoise library is not in use.
Fixes #399
Type of change
Please select the option(s) that is more relevant.