chore: address new works for you comments #9935
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
changed the title
MounirDhahri
force-pushed
the
fix/show-the-right-version
branch
2 times, most recently
from
c7c32b9
to
5506987
Compare
MounirDhahri
force-pushed
the
fix/show-the-right-version
branch
from
5506987
to
3d224d8
Compare
MounirDhahri
requested review from
olerichter00
and removed request for
olerichter00
olerichter00
approved these changes
Mar 13, 2024
Comment on lines
+29
to
+52
| const [hasChangedLayout, setHasChangedLayout] = useState(false) | ||
|
|
||
| const firstUpdate = useRef(true) | ||
|
|
||
| // This is a hack to force the grid to re-render when the layout changes | ||
| // Flashlist makes a werid animation when changing between numColumns | ||
| // We avoid it by showing the placeholder for a second while it's happening | ||
| useLayoutEffect(() => { | ||
| if (firstUpdate.current) { | ||
| firstUpdate.current = false | ||
| return | ||
| } | ||
|
|
||
| setHasChangedLayout(true) | ||
| }, [numColumns]) | ||
|
|
||
| if (hasChangedLayout) { | ||
| setTimeout(() => { | ||
| setHasChangedLayout(false) | ||
| LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut) | ||
| }, 1000) | ||
|
|
||
| return <NewWorksForYouPlaceholder /> | ||
| } |
There was a problem hiding this comment.
What do you think about moving this logic into MasonryInfiniteScrollArtworkGrid and converting it into a hook to avoid duplication? I guess, this issue will arise wherever i't possible to change the number of columns.
| const artworks = extractNodes(data.artworks) | ||
| const numColumns = defaultViewOption === "grid" ? NUM_COLUMNS_MASONRY : 1 | ||
|
|
||
| const [hasChangedLayout, setHasChangedLayout] = useState(false) |
There was a problem hiding this comment.
Instead of using/overriding a layout animation here, could we simply show the placeholder between the column change? I'm thinking of something like this inside of MasonryInfiniteScrollArtworkGrid:
const [internalNumColumns, setInternalNumColumns] = useState(numColumns)
const [showPlaceholder, setShowPlaceholder] = useState(false)
useEffect(() => {
showPlaceholder(true)
}, [numColumns])
useEffect(() => {
if (!showPlaceholder) return
setInternalNumColumns(numColumns)
showPlaceholder(false)
}, [showPlaceholder])
dariakoko
approved these changes
Mar 13, 2024
Comment on lines
+72
to
+78
| useEffect(() => { | ||
| if (hideTitle) { | ||
| if (currentScrollY >= NAVBAR_HEIGHT) { | ||
| setHideTitle(false) | ||
| } | ||
| } | ||
| }, [currentScrollY]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-840
Description
The goal from this PR is addressing the design comments on the New Works For You screen raised by Barney and removing the old logic.
Before
Screen.Recording.2024-03-06.at.12.11.59.mov
After
Screen.Recording.2024-03-12.at.17.04.53.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.