Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error messages to view in room #10182

Merged
merged 1 commit into from May 2, 2024
Merged

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented May 1, 2024

This PR resolves PHIRE-783

Description

I couldn't reproduce view in room not working altogether but did see that we don't handle the unhappy path at all and fail silently when either a user is pointing a non-vertical surface or the cursor is initializing. This might lead people to think it isn't working.

This adds a little error message to explain what is going on when an artwork cannot be placed:
IMG_2359
IMG_2360

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 馃憖

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

  • Add user facing errors to view in room - brian

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this May 1, 2024
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • iOS user-facing changes (Add user facing errors to view in room - brian)

Generated by 馃毇 dangerJS against 3f251fb

Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable 馃憦

@brainbicycle brainbicycle merged commit 1d8aa71 into main May 2, 2024
7 checks passed
@brainbicycle brainbicycle deleted the brian/view-in-room-bug branch May 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants