fix: search input line break #10167
fix: search input line break #10167
Conversation
MounirDhahri
force-pushed
the
fix/search-input-text-crop
branch
from
fff8557
to
b201507
Compare
| // See https://github.com/facebook/react-native/issues/29663 | ||
| const SEARCH_INPUT_PLACEHOLDER = | ||
| Platform.OS === "android" && Dimensions.get("screen").width - 150 < 250 | ||
| ? "Search artists, artworks, etc" |
There was a problem hiding this comment.
Here I am simply sending a short version of the placeholder for small devices
There was a problem hiding this comment.
Suggestion (non-blocking): Although this fixes the issue that was reported, I believe that implementing something similar to the workaround (that was introduced here) over all inputs would be a better solution
There was a problem hiding this comment.
this was unfortunately not used anywhere after this PR so I removed it from palette. Let me check again if I should bring that back
There was a problem hiding this comment.
I think his solution was nice but I'd rather avoid having a shadow element in the tree, if we could have something like Pavlos did but once we're done with the measuring we get rid of the shadow element from the tree would be nice, if it's not too much work 馃憤
|
Here we go artsy/palette-mobile#225 |
This PR resolves ONYX-931
Description
This PR fixes an issue where the search input placeholder breaks on Android.
The issue comes from React-native and is still not fixed even in the latest version.
PR Checklist
To the reviewers 馃憖
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.