Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate submission required fields #10142

Closed
wants to merge 3 commits into from

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Apr 24, 2024

This PR resolves ONYX-816

Description

This PR updates the submission required fields

Screen.Recording.2024-04-24.at.17.31.00.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 馃憖

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • validate submission required fields

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Apr 24, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (validate submission required fields)

Generated by 馃毇 dangerJS against 9c5798f

@MounirDhahri MounirDhahri changed the title chore: validate submission required fields [DRAFT] chore: validate submission required fields Apr 25, 2024
@MounirDhahri MounirDhahri force-pushed the chore/validate-required-fields branch from c0935c5 to 276799b Compare April 25, 2024 13:44
@MounirDhahri MounirDhahri self-assigned this May 3, 2024
@MounirDhahri MounirDhahri marked this pull request as draft May 3, 2024 15:17
@MounirDhahri MounirDhahri force-pushed the chore/validate-required-fields branch from 276799b to 9c5798f Compare May 3, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants