chore: update required fields for submission #10140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
chore/update-required-fields-for-submissions
branch
2 times, most recently
from
04797e7
to
ba22930
Compare
MounirDhahri
changed the title
| @@ -56,6 +56,13 @@ export const ArtworkDetailsForm: React.FC = () => { | |||
| accessibilityLabel="Title" | |||
| /> | |||
| <StandardSpace /> | |||
| <CategoryPicker<AcceptableCategoryValue | null> | |||
There was a problem hiding this comment.
nitpick: Would it make sense to add null as a possible value to AcceptableCategoryValue?
There was a problem hiding this comment.
I wanted to keep my changes to a minimum since this was there already and I only moved it down - I will see if it's a quick change
There was a problem hiding this comment.
Leaving it here sounds like a good idea then 馃憤
src/app/Scenes/SellWithArtsy/mutations/updateConsignSubmissionMutation.ts
Outdated
Show resolved
Hide resolved
dblandin
reviewed
Apr 29, 2024
src/app/Scenes/SellWithArtsy/mutations/updateConsignSubmissionMutation.ts
Outdated
Show resolved
Hide resolved
src/app/Scenes/SellWithArtsy/SubmitArtwork/ArtworkDetails/validation.ts
Outdated
Show resolved
Hide resolved
MounirDhahri
force-pushed
the
chore/update-required-fields-for-submissions
branch
from
ba22930
to
eb9792f
Compare
MounirDhahri
force-pushed
the
chore/update-required-fields-for-submissions
branch
from
3e0a94c
to
41fc71d
Compare
MounirDhahri
force-pushed
the
chore/update-required-fields-for-submissions
branch
3 times, most recently
from
9e3bc20
to
e4a9ba0
Compare
MounirDhahri
force-pushed
the
chore/update-required-fields-for-submissions
branch
from
e4a9ba0
to
09a3f17
Compare
olerichter00
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-903
Description
This PR updates the required fields for submissions in-app to be (artist, title and category)
PR Checklist
To the reviewers 馃憖
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.