Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(EMI-1796): Mark AREnablePartnerOfferOnArtworkScreen as ReadyForRelease #10128

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Apr 23, 2024

This PR resolves EMI-1796

Description

This PR marks AREnablePartnerOfferOnArtworkScreen as ReadyForRelease in preparation to release the feature

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • mark AREnablePartnerOfferOnArtworkScreen as ready for release - mrsltun

Need help with something? Have a look at our docs, or get in touch with us.

@MrSltun MrSltun self-assigned this Apr 23, 2024
@MrSltun MrSltun changed the title chore(EMI-1796): Mark AREnablePartnerOfferOnArtworkScreen as ReadyForRelease [DO-NOT-MERGE] chore(EMI-1796): Mark AREnablePartnerOfferOnArtworkScreen as ReadyForRelease Apr 23, 2024
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (mark AREnablePartnerOfferOnArtworkScreen as ready for release - mrsltun)

Generated by 🚫 dangerJS against 910836a

@MrSltun MrSltun changed the title [DO-NOT-MERGE] chore(EMI-1796): Mark AREnablePartnerOfferOnArtworkScreen as ReadyForRelease chore(EMI-1796): Mark AREnablePartnerOfferOnArtworkScreen as ReadyForRelease Apr 26, 2024
@MrSltun MrSltun marked this pull request as ready for review April 26, 2024 09:40
@MrSltun MrSltun added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Apr 26, 2024
@artsy-peril artsy-peril bot merged commit c485d90 into main Apr 26, 2024
8 checks passed
@artsy-peril artsy-peril bot deleted the mrsltun/EMI-1796/mark-AREnablePartnerOfferOnArtworkScreen-as-ReadyForRelease branch April 26, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants