Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Interested in Selling tooltip to MyC #10121

Conversation

olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Apr 22, 2024

This PR resolves ONYX-867

Description

This adds an "Interested in Selling?" tooltip to My Collection if the first artwork in the list is from a P1 artist. The tooltip only shows up once and is hidden after the user has seen it.

Simulator Screenshot - iPhone 15 Pro - 2024-04-29 at 12 09 59

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 馃憖

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Add "Interested in Selling?" tooltip to My Collection - ole

iOS user-facing changes

  • Add Interested in Selling tooltip to My Collection (only if first artwork is from P1 artist) - ole

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Apr 22, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (Add "Interested in Selling?" tooltip to My Collection - ole)
  • iOS user-facing changes (Add Interested in Selling tooltip to My Collection (only if first artwork is from P1 artist) - ole)

Generated by 馃毇 dangerJS against b66fa4b

@olerichter00 olerichter00 self-assigned this Apr 22, 2024
@olerichter00 olerichter00 marked this pull request as draft April 22, 2024 14:11
@olerichter00 olerichter00 force-pushed the olerichter00/ONYX-867/add-interested-in-selling-tooltip-to-myc branch 2 times, most recently from 1c20780 to a656b94 Compare April 29, 2024 10:31
@olerichter00 olerichter00 marked this pull request as ready for review April 29, 2024 10:33
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! sorry for the late review

@olerichter00 olerichter00 force-pushed the olerichter00/ONYX-867/add-interested-in-selling-tooltip-to-myc branch from cecdadc to 505e270 Compare May 2, 2024 11:41
@olerichter00 olerichter00 added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label May 2, 2024
@olerichter00 olerichter00 force-pushed the olerichter00/ONYX-867/add-interested-in-selling-tooltip-to-myc branch from 505e270 to b66fa4b Compare May 3, 2024 11:13
@artsy-peril artsy-peril bot merged commit a4edde1 into main May 3, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the olerichter00/ONYX-867/add-interested-in-selling-tooltip-to-myc branch May 3, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants