Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ONYX-662): display error message on alert edit/add #10010

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Mar 28, 2024

This PR resolves [(ONYX-662)]

Description

Display generic error dialog if Error occurs

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 馃憖

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • display error message on alert edit/add - daria

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@artsy-peril
Copy link
Contributor

artsy-peril bot commented Mar 28, 2024

Warnings
鈿狅笍 Please assign someone to merge this PR, and optionally include people who should review.

Generated by 馃毇 dangerJS against c465142

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Mar 28, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (display error message on alert edit/add - daria)

Generated by 馃毇 dangerJS against c465142

@dariakoko dariakoko self-assigned this Apr 19, 2024
Copy link
Contributor

@nickskalkin nickskalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃檶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants