test(publish-metrics): add tests for otel tracing #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InesNi
changed the title
InesNi
changed the title
InesNi
force-pushed
the
ifazlic-art-1735-write-tests-for-parallel
branch
from
0faa470
to
816cdeb
Compare
2 tasks
InesNi
force-pushed
the
ifazlic-art-1735-write-tests-for-parallel
branch
2 times, most recently
from
084d519
to
1961a50
Compare
InesNi
force-pushed
the
ifazlic-art-1735-write-tests-for-parallel
branch
from
95ea16e
to
7c48e3d
Compare
2 tasks
hassy
reviewed
May 23, 2024
| @@ -44,7 +44,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "test:unit": "tap --no-coverage --timeout=420 --color test/unit/*.test.js", | |||
| "test:acceptance": "export ARTILLERY_TELEMETRY_DEFAULTS='{\"source\":\"test-suite\"}' && tap --no-coverage --timeout=420 test/cli/*.test.js && bash test/lib/run.sh && tap --no-coverage --color test/testcases/plugins/*.test.js", | |||
| "test:acceptance": "export ARTILLERY_TELEMETRY_DEFAULTS='{\"source\":\"test-suite\"}' && tap --no-coverage --timeout=420 test/cli/*.test.js && bash test/lib/run.sh && tap --no-coverage --color test/testcases/plugins/*.test.js && tap --no-coverage --color --timeout=3000 test/publish-metrics/*/*.test.js", | |||
There was a problem hiding this comment.
do the timeouts need to be this long? (here and in https://github.com/artilleryio/artillery/pull/2718/files#diff-be85fb016971de4211dd6960474754c38e876ae617df1435e47e3b26261e2847R9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing tests for
publish-metricstracing.FileSpanExporteris created for testing purposes and is enabled through theexporterand__outputPathsetting in the OTel reporter configuration:Both the
ConsoleSpanExporterandInMemorySpanExporterwere considered for testing purposes but creating a custom file exporter ended up being the most straightforward option with the least possible change to the logic of the OTel reporter.An extensive test for the
HTTPengine tracing basic functionality support has been added including a test for theparallelscenario configuration and test runs with errors.Pre-merge checklist