Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow scenario name exact match without using regex #2709

Conversation

bernardobridge
Copy link
Contributor

Description

Addresses #2673 by allowing regex or exact match. I think this allows the maximum flexibility for the flag without breaking any existing workflows.

Pre-merge checklist

  • Does this require an update to the docs? Yes (need to explain how the feature works - regex vs exact match)
  • Does this require a changelog entry? Yes

@bernardobridge bernardobridge requested a review from a team May 7, 2024 11:59
@bernardobridge bernardobridge force-pushed the bernardobridge/art-1790-change-scenario-name-to-be-exact-match-rather-than-regex branch from 73b1dfe to 65dfb5d Compare May 9, 2024 18:13
@bernardobridge bernardobridge force-pushed the bernardobridge/art-1790-change-scenario-name-to-be-exact-match-rather-than-regex branch from 65dfb5d to f17daf2 Compare May 9, 2024 21:28
@HugoImaios
Copy link

seems like the more pragmatic choice indeed ! Thanks @bernardobridge !

@bernardobridge bernardobridge force-pushed the bernardobridge/art-1790-change-scenario-name-to-be-exact-match-rather-than-regex branch from e54bae5 to dd63f78 Compare May 13, 2024 14:21
@bernardobridge bernardobridge merged commit 88e686a into main May 13, 2024
22 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1790-change-scenario-name-to-be-exact-match-rather-than-regex branch May 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants