Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue 2476): resolve config templates before bundling test packages #2477

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jogura
Copy link

@jogura jogura commented Feb 5, 2024

Address Issue #2476

  • Fix both createBom paths for Lambda & ECS
  • Resolve the the config templates before attempting to find files to include/copy
  • Passes the cliOptions to the createBom functions

TODO:

  • Fix unit tests

* Fix both `bom` creation Lambda & ECS
* Resolve the the config templates before attempting to find files to include/copy
* Passes the `cliOptions` to the `createBom` function

TODO:
* Fix unit tests
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@bernardobridge
Copy link
Contributor

Hi @jogura 👋

Thanks for the contribution. A couple of things:

  • We would need the CLA sign in order to accept contributions. Will you be able to do it?
  • We have actually implemented part of the change here (fixing the behaviour for Fargate) recently. Would you be able to rebase with main?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants