Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR
Please, I have some doubts and I need your help to finish it.
🏁
This PR is the final review for #9.
All the checks for
1.7
are OK with this PR.📝
All the changes in this PR will be avoided with the use of the files in
drafts
directory for the next contributions:C++
code wasn't extracted for translation. JustHaskell
code. So, this PR removes all theC++
code and the corresponding translations. I feel your pain...🆘
I need your help with these points.
src/main/ank/1.7-functors-Part1.md
As far as I know, Kotlin doesn't differentiate function declaration and function definition.
In general, all the snippets have been extracted without separating declaration and definition.
However, there are a special case in this file
1.7-functors-Part1.md
from line 28. There are 2 snippets with declarations and another one with the definition.They are related with the explanation about functions curried by default in Haskell.
So the book includes two different and equivalent ways of declaration for the same function and, then, the definition.
What's pending?
src/main/ank/1.7-functors-Part3.md
Pending translations for these 2 missing snippets in Haskell:
line2: (->) a b
line9: (->) a