Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: section 1.7 #58

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix: section 1.7 #58

wants to merge 1 commit into from

Conversation

rachelcarmena
Copy link
Member

⚠️

This is a draft PR
Please, I have some doubts and I need your help to finish it.

🏁

This PR is the final review for #9.
All the checks for 1.7 are OK with this PR.

📝

All the changes in this PR will be avoided with the use of the files in drafts directory for the next contributions:

  • Some snippets have been joined. They were separated for Kotlin translation but they have been extracted together from the book. I joined the corresponding translations as well.
  • Sorry, C++ code wasn't extracted for translation. Just Haskell code. So, this PR removes all the C++ code and the corresponding translations. I feel your pain...
  • Other snippets have been removed. See more reasons in this closed issue. I feel your pain again...

🆘

I need your help with these points.

src/main/ank/1.7-functors-Part1.md

As far as I know, Kotlin doesn't differentiate function declaration and function definition.

In general, all the snippets have been extracted without separating declaration and definition.

However, there are a special case in this file 1.7-functors-Part1.md from line 28. There are 2 snippets with declarations and another one with the definition.

They are related with the explanation about functions curried by default in Haskell.

So the book includes two different and equivalent ways of declaration for the same function and, then, the definition.

What's pending?

  • Remove the translations for the declarations
  • Chose one the previous translations for the definition (it's empty now, because that snippet was missing)

src/main/ank/1.7-functors-Part3.md

Pending translations for these 2 missing snippets in Haskell:

  • line2: (->) a b
  • line9: (->) a

@rachelcarmena rachelcarmena mentioned this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant