-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please include glad directly into forge #236
Comments
Forge (ArrayFire also) uses a specific workflow for fetching dependencies like glad, glm etc. for building the concerned project. I believe it is better to be consistent on how CMake fetches dependencies if possible, which it is in the case of glad for forge/arrayfire. I am not a fan of including large source files into the repository, especially when CMake can help with the same. Also, please note that, all this dependency handling is taken care by the
Sure, that is one way to do it. Again subtree is nothing but maintaining a copy of those sources in the downstream project which we want to avoid. We used to have similar dependencies as submodules, but we removed those in favor of CMake's fetch content which lets us handle the case of
In a way, what's transpiring now is akin to the above suggestion. The difference being, we keep the glad sources that arrayfire and forge needs in separate repository and we re-use that directly in our CMake. As far as the offline builds are concerned, every release of forge uploads a full code base of forge that includes the dependencies also as forge-full-x.x.x.tar.bz2 GitHub release asset. I am not suggesting the workflow of arrayfire/forge is the best route but it definitely addresses the uses cases we want to handle.
|
Closing due to inactivity, please re-open if required after reviewing my above response. |
The "forge-full" tarball is broken - Please try to build it without any network connection, it will fail with the following output:
|
Current setup of glad dependency makes it unnecessary hard to build:
forge should either include the pregenerated glad sources as a git subproject, or use a plain upstream glad and configure it at build time.
The text was updated successfully, but these errors were encountered: