Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Bundled "extern" sources in tarball broken #3527

Open
StefanBruens opened this issue Jan 4, 2024 · 2 comments
Open

[Build] Bundled "extern" sources in tarball broken #3527

StefanBruens opened this issue Jan 4, 2024 · 2 comments
Labels

Comments

@StefanBruens
Copy link

af_dep_check_and_populate calls FetchContent_Populate, which tries to update the sources, but fails as the shipped sources do not contain the required .git subdirectory.

Description

AF uses the multi-argument form of FetchContent_Populate:

https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_populate

This form has a number of key differences to that where only <name> is provided:

  • ...
  • The FETCHCONTENT_FULLY_DISCONNECTED and FETCHCONTENT_UPDATES_DISCONNECTED cache variables are ignored.

AF should use FetchContent_Declare + FetchContent_MakeAvailable instead, so a fully disconnected build from the source tarball can actually work.

@StefanBruens
Copy link
Author

See also arrayfire/forge#236

@9prady9
Copy link
Member

9prady9 commented Jan 9, 2024

The tarball generation is automated and the files being included was tested before we finalised on this particular workflow. If for some reason, this is failing it needs to be looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants