Join does not always respect the order of provided parameters (#3511) #3513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays were be joined in the order the JIT engine generated the arrays iso the order of the parameters.
Description
This assumption is violated when one of the generated arrays is an intermediate result of a previous specified JIT generated array.
Example of error condition:
In this fix, the order of the parameters is imposed, independent from the order of JIT generation.
PS: This bug appears in OPENCL and CUDA.
As result, a different kernel could be executed than intended, dependent on the order of the JIT kernel generation.
Additional information about the PR answering following questions:
Fixes: #3511
Changes to Users
None
Checklist