Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARQ-2230] Integrate the checkstyle plugin #540

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[ARQ-2230] Integrate the checkstyle plugin #540

wants to merge 9 commits into from

Conversation

petrberan
Copy link
Collaborator

@petrberan petrberan commented Mar 1, 2024 •
edited

@petrberan petrberan changed the title Add checkstyle plugin [ARQ-2230] Integrate the checkstyle plugin Mar 7, 2024
jasondlee
jasondlee previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@jasondlee jasondlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rhusar
rhusar approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over all of these and these look good.

As I mentioned on the call, I would avoid reformatting half of the code base in a single PR but this is not doing that - this is fixing the basics.

@asoldano
Copy link

asoldano commented Apr 2, 2024

@petrberan looks like this should be rebased?

@rhusar
Copy link
Contributor

rhusar commented Apr 2, 2024

@asoldano Yes - this needs to be rebased and fix the mess introduced in https://github.com/arquillian/arquillian-core/pull/541/files/b094f449153bf917a1eba6bf235ca283ac17d1ba#diff-8fe6da14bb5c6c5bff09ecf520a4b8d878dc247bed09dd15aafe9431a6e1ea00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar approved these changes

@jasondlee jasondlee jasondlee left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petrberan @asoldano @rhusar @jasondlee @starksm64