New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added integration tests for JUnit 5 lifecycle methods #314
base: master
Are you sure you want to change the base?
Added integration tests for JUnit 5 lifecycle methods #314
Conversation
Tests will fail until App server tests are set up and #310 is merged |
I am not really convinced these tests should live in the core, as they are also dependent on the application server adapter which is a separated entity and can or cannot support particular feature for whatever reason. My initial thinking is to resurrect |
I think you are right about all of that. There can easily be some module that does integration testing with a container |
Lemme get a bit deeper to it and we will definitely put your valuable to good use :) |
13a9da2
to
dc1fa3b
Compare
@bartoszmajsak I figured out how to do integration tests properly with app servers, so here is the fixed version of this PR. |
@bartoszmajsak what do you think? |
ed39c52
to
ae95fa4
Compare
Any chance of getting this merged? |
3584b11
to
eb7e308
Compare
@lprimak As I mentioned in #314 (comment) I am reluctant to make this part of |
Do you think there is harm to merge this and then later when you have time, you can fix it to your liking? |
If there's something I learned the hard way in my software engineering journey it can be summarized as
I would rather start with something small and separate which can give us an answer "does Arqulian with XUnit work with P Container Adapter" rather than introducing another module to the |
True true, however, there also "iterative development" argument here :) |
@bartoszmajsak I think this is still relevant, can we make some progress here? |
cdbb31c
to
88a0e06
Compare
88a0e06
to
e9268d0
Compare
Short description of what this resolves:
Integration tests for lifecycle methods with JUnit 5
Relates to #310 #309 and #301
using
@TempDir
as a base for temporary directoryCould not use it 'as is' because it gets deleted for each test class,
but the files need to be kept throughout the test suite