Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARQ-622 Support global configuration #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Oct 30, 2011

Hi,
not sure if what I've done is correct but I've added a system properties to configure the folder in which the arquillian.xml can be found.

It first looks in the classpath and if a configuration is not found it looks in the "global folder" (default to ~/.arquillian). The name of the file to look for is the one specified in the arquillian.xml system property.

Cheers

@lordofthejars
Copy link
Member

@DavideD I like this idea, I am going to work so it can be added in next release of Arquillian. cc/ @bartoszmajsak

@DavideD
Copy link
Member Author

DavideD commented Nov 15, 2016

Wow, what a nice suprirse :)

@lordofthejars
Copy link
Member

@DavideD currently there is a workaround for this feature and it is using system properties to define the extension values. But of course configuring a global arquillian.xml might a really good idea for CI/CD environments. What we need to discuss is if we merge both files in case of having classpath one and global one. Or which takes more precedence. @bartoszmajsak

@DavideD
Copy link
Member Author

DavideD commented Nov 15, 2016

My way to go in these cases is that the local one override the global one.

Just my 0.02 cents

@bartoszmajsak
Copy link
Member

I would say local takes precedence, I guess that's common behaviour / expectation.

@lordofthejars
Copy link
Member

You mean by ignoring the global one and just use the local one, or doing some kind of merge between both of them?

@bartoszmajsak
Copy link
Member

Precedence == override given property

@lordofthejars
Copy link
Member

lordofthejars commented Nov 15, 2016

ok, it has sense doing property by property. But I know that the common case is that local takes precedence over global, but let me describe next case:

I have configured arquillian cube. Locally I use docker machine so all arquillian.xml is configured for using docker machine. But my CI environment uses native docker, so I would like to use this configuration.

At this time I cannot use the override since the local has more precedence than the global, so at the end I need to use the old approach of having to define all environment variables and so on.

So what I see is that the global one is something for CI/CD environments and not to be used by developer so from this point of view global should take precedence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants