Added Bootstrap & Fontawesome. #2
Conversation
chrisjimallen
changed the title
|
|
||
| <div class="starter-template"> | ||
| <h1>Webpack 3 QuickStarter Template!</h1> | ||
| <i class="fa fa-thermometer-three-quarters" aria-hidden="true"></i> |
There was a problem hiding this comment.
Its just to demonstrate the font awesome is working correctly.
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| "extends": "standard" | |||
There was a problem hiding this comment.
Added standard linting, as it seems to be the least annoying.
| @@ -18,14 +18,28 @@ | |||
| "babel-preset-env": "~1.6.0", | |||
| "clean-webpack-plugin": "~0.1.17", | |||
| "css-loader": "~0.28.7", | |||
| "eslint": "^4.16.0", | |||
There was a problem hiding this comment.
All of these linting packages aren't really necessary. Feel free to remove what you like.
| @@ -52,10 +53,9 @@ const config = { | |||
| }) | |||
| }, | |||
| // file-loader(for images) | |||
| { test: /\.(jpg|png|gif|svg)$/, use: [ { loader: 'file-loader', options: { name: '[name].[ext]', outputPath: './assets/media/' } } ] }, | |||
| { test: /\.(jpg|png|gif|svg)$/, exclude: /(\/fonts)/, use: [{ loader: 'file-loader', options: { name: '[name].[ext]', outputPath: './assets/media/' } }] }, | |||
There was a problem hiding this comment.
Excludes fonts directory as font awesome also uses SVG fonts.
| // file-loader(for fonts) | ||
| { test: /\.(woff|woff2|eot|ttf|otf)$/, use: ['file-loader'] } | ||
|
|
||
| { test: /\.(woff|woff2|eot|ttf|otf|svg)$/, exclude: path.resolve(__dirname, 'assets', 'media'), use: [{ loader: 'file-loader', options: { name: '[name].[ext]', outputPath: './assets/fonts/' } }] } |
There was a problem hiding this comment.
Exclude the media directory, as we only care about fonts here.
|
Hi @chrisjimallen, Sorry that I've been here like a month later after a long vacation. It was so great to have you contributing on this repo. And I can't thank you enough for that. And I was thinking about merging your changes into the repo. But I had another thought, because the article was only for the basic boilerplate with webpack and honestly speaking I don't use bootstrap anymore, and maybe the readers of this article might not too. I guess, it will be a better decision to create a new branch while your changes will be merged and we can manage another boilerplate for bootstrap and fontawesome setting on webpack. |
Have a look, see what you think and feel free to change whatever you like ;)